Change video dimensions depending on orientation #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmmgc Hello, can i ask you to explain what exactly are you fixing with this? i have similar issue but it only happens with screen recorded videos, for some reason it returns video width as height, is this what your commit is trying to fix? |
Author
|
@maksymhcode-care Yes, pretty much. It checks if video was recorded in portrait mode and corrects width and hight before sending it back to JS. However, this patch is made long time ago, I am not sure it this is still needed. |
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR is related to wrong video dimensions on iOS (#1504). As this is open a long time, I am not sure if there is intention to "fix" this.
This is adjusting width and height directly. Another option would be to expose orientation value in response object so devs can adjust it on JS side.